[milters] Archive

Lists Index Date Thread Search

Article: 1279
From: Mathias Koerber
Date: 2006-11-23 03:02:34 -0500
Subject: bug in milter-gris:

Removal...........: milters-request@milter.info?subject=remove
More information..: http://www.milter.info/#Support
--------------------------------------------------------

I got this from Rene Berber <milters@legosoft.com.mx> which never
made it to the list. I think others may be interested as well.


> By accident, I saw that one specific email keeps consistently
> rejected even though the 600 seconds are long over:
 [snip]
> Has anyone else ever seen this (and may have a cause/solution)?
> any help would be very much appreciated

Yes, milter-gris 0.19 has a race condition that I reported a while
back (but my messages are apparently being blocked, both to the list
and to Anthony's address)... in case this message does make it
through the lines in question are:

--- milter-gris.c-orig	2006-07-23 12:06:09.000000000 -0500
+++ milter-gris.c	2006-09-02 05:36:37.244599000 -0500
@@ -346,7 +346,8 @@

 	entry->count++;
 	entry->status = status;
-	entry->touched = time(NULL);
+	if (status != SMFIS_TEMPFAIL)
+		entry->touched = time(NULL);

 	DataInitWithBytes(&value, (unsigned char *) entry, sizeof (*entry));
 	rc = cache->put(cache, &key, &value);

Lists Index Date Thread Search