[milters] Archive

Lists Index Date Thread Search

Article: 650
From: Matanya Elchanani
Date: 2005-07-11 18:53:01 -0400
Subject: SPF API problems - proposed patch

Removal...........: milters-request@milter.info?subject=remove
More information..: http://www.milter.info/#Support
--------------------------------------------------------

I think I found the problem. In the 'include' check, you recurse into
spfCheck(), but when you come back, you do not reload the result of the
recursive search back into the qualifier. Here's a patch:

=============================>8====================================
--- spf.c.org   Mon Jul 11 18:25:44 2005
+++ spf.c       Mon Jul 11 18:42:54 2005
@@ -433,6 +433,7 @@
                        }

                        err = spfCheck(ctx, term+8);
+                       qualifier = ctx->result;
                        switch (qualifier) {
                        case SPF_PASS:
                        case SPF_NONE:
=============================>8====================================

msn.com now correctly SOFTFAIL's on IP's not in the range, and debug data
shows that the routines correctly recurse and scan through all the four
includes.

Sincerely,

--
Matanya


Lists Index Date Thread Search